Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and fix issues raised by Python QA tools #162

Merged
merged 7 commits into from
Jan 12, 2024
Merged

Update and fix issues raised by Python QA tools #162

merged 7 commits into from
Jan 12, 2024

Conversation

guilieb
Copy link
Contributor

@guilieb guilieb commented Jan 9, 2024 •
edited
Loading

  • Update pre-commit tools version numbers
  • Fix the issues raised by the pre-commit tools (new mypy errors & pyupgrade suggestions).
  • Remove un-necessary x permission on some non-source files.
  • Add a simple ruffconfiguration in pyproject and add it in the dev group of dependencies.
  • Harmonize the location of configuration to pyproject.toml instead of having explicing args in pre-commit-config.yaml.
  • Add a GitHub Actions with pre-commit

@guilieb guilieb force-pushed the feature/qa-improvements branch 3 times, most recently from a5a916b to d5affac Compare January 10, 2024 15:27
@guilieb guilieb changed the title WIP: Update and fix issues raised by Python QA tools Update and fix issues raised by Python QA tools Jan 10, 2024
@guilieb guilieb force-pushed the feature/qa-improvements branch from d5affac to 4fb5bf9 Compare January 12, 2024 08:06
@HugoPerrier HugoPerrier merged commit 6dc8197 into MAIF:master Jan 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HugoPerrier HugoPerrier HugoPerrier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guilieb @HugoPerrier