Conversation
hrodmn
left a comment
There was a problem hiding this comment.
Thanks for adding this! My only request is to export the pgbouncer instance names from the pgstacinfra stacks so we can provide the full names as props instead of just the stage name.
Do you think any of this could/should be fed back into eoapi-cdk's pgbouncer infrastructure?
I think that it should in some sense, but looking at how we deploy the infrastructure it got a little messy when I was first defining it. I wouldn't want multiple maintenance windows/patch managers for our use case - one pgSTAC and one userSTAC but both are technically one environment. Do you think there's a way to define this infrastructure alongside the pgbouncer constructs without generating multiple maintenance windows/patch managers? or do you think I should add an optional default one that we wouldn't use in our case? |
I think it would make sense to add the capability to eoapi-cdk when pgbouncer is enabled since it shouldn't incur much cost (right?). I see why you would just want the one patch manager in this case, so maybe it would be nice to make it togglable. |
2bca53f to
86d7633
Compare
hrodmn
left a comment
There was a problem hiding this comment.
Looks good! Do we need to turn off the patch manager that comes with eoapi-cdk now? I upgraded our deployment to use the new version that includes the patch manager feature that you made.
Description