feat(browser): add native desktop Browser workspace - #88
Merged
wolfiesch merged 3 commits intoJul 20, 2026
Conversation
Contributor
Author
|
@lyc-aon hey I need this pushed through ASAP -- high priority, blocking our team, and the stakeholders are angry. Need it done by 10PM EST tonight. Get your nerds on it. Thanks! |
Collaborator
Thanks for the tightly scoped PR! I'm reviewing it now - will make sure it's included in the next T4 release (usually a couple hours) |
Collaborator
|
Made a few quick changes on top of this PR:
All required checks pass. |
Contributor
Author
|
Thank you, you are Roy's greatest soldier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
pnpm devbuild the desktop bundle, reserve a free renderer port, wait for Vite readiness, launch Electron with a validated loopback URL, and supervise both child processes.How you verified it
pnpm check— release consistency, provenance, lint, and typecheck passed against v0.1.29.pnpm test— all packages passed; desktop: 25 files / 155 tests, web: 74 files / 1086 tests.pnpm build— all workspace builds passed.pnpm devlaunched Electron on a dynamically selected renderer port and remained running.https://example.com/, and observedExample Domainin theReadystate.Checklist
pnpm checkpasses (release contract, provenance, lint, typecheck)pnpm testpasses; new behavior has tests that fail without this changeTHIRD_PARTY_NOTICES.mdAI Review Report
Two independent reviews traced the complete change set across protocol, client, desktop runtime, preload, web workspace, and launcher. Review findings were remediated before push: page-initiated navigation guards, managed popup denial, shared-session permission lifetime, profile-session download routing, authenticated-profile reference counts and opt-in, OMP-session surface ownership, and per-surface screenshot state. Focused regressions were added for each corrected boundary.
Security Audit
The audit covered renderer-to-main IPC validation, native navigation and popup policy, profile isolation, permission routing, downloads and filename containment, proxy/auth/certificate handling, preload exposure, automation bounds, process spawning, and secret leakage. High-confidence findings were fixed before push; the final full check, test, and build gates passed.