fix: retry transient macOS service upgrades - #81
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR hardens macOS service upgrades against launchd’s asynchronous service-removal window by adding a narrowly scoped, time-bounded retry for launchctl bootstrap failures classified as transient (“Operation already in progress” / exit code 37). This prevents upgrades from rolling back to prior backends or leaving the Tailnet phone gateway stopped during the brief replacement race.
Changes:
- Add a retry loop (max ~3s, 100ms backoff) that only applies to
launchctl bootstraptransient EINPROGRESS-style failures. - Apply the same transient classification + bounded retry behavior in both the Tailnet gateway installer script and the service-manager package.
- Add targeted tests covering the retry classification and the specific upgrade race.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/tailnet-service.mjs | Adds transient-error classification and bounded retry around launchctl bootstrap execution. |
| scripts/tailnet-service.test.mjs | Adds unit test ensuring only the intended launchctl bootstrap error is retryable. |
| packages/service-manager/src/index.ts | Adds bounded retry logic in runChecked for transient launchctl bootstrap failures. |
| packages/service-manager/test/service-manager.test.ts | Adds lifecycle test validating MacLaunchAgentManager.install() retries bootstrap during removal window. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Mac app upgrades now survive launchd’s asynchronous service-removal window instead of restoring the previous backend or leaving the phone gateway stopped.
Changes
launchctl bootstraperror 37 /Operation already in progressfor up to three secondsVerification
mise exec node@24.13.1 -- pnpm checkmise exec node@24.13.1 -- pnpm test(1,586 tests)