fix: restore configured phone access on launch - #73
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ee3e1ce389
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR restores previously configured private phone access automatically when the packaged desktop app launches, and tightens the “ready” signal so it’s only reported after the gateway and local OMP runtime are healthy. It also updates phone setup instructions to include iOS VPN On Demand guidance.
Changes:
- Add a startup restore path for phone access and invoke it during packaged desktop app initialization.
- Update phone access health/ready evaluation to wait for a healthy gateway and to surface an error when Serve is configured but the local OMP runtime is unhealthy.
- Expand documentation and UI instructions with iOS “VPN On Demand” reconnect steps.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| docs/TAILNET_REMOTE.md | Adds iOS VPN On Demand guidance for automatic reconnect. |
| apps/web/src/features/targets/TargetsScreen.tsx | Updates the phone setup checklist shown in the UI to include VPN On Demand steps. |
| apps/desktop/test/phone-setup.test.ts | Adds/updates tests covering restore-on-launch and unhealthy local runtime behavior. |
| apps/desktop/src/phone-setup.ts | Implements restore flow and gateway health polling; refines readiness/error states. |
| apps/desktop/src/lifecycle.ts | Triggers phone access restore during packaged app startup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Outcome
Previously configured private phone access restarts automatically when the packaged desktop app opens. Setup now reports ready only after the gateway and local OMP runtime are healthy, and the phone instructions include iOS VPN On Demand.
Verification
pnpm checkpnpm test(70 files, 984 tests)pnpm package:mac:unsigned