Skip to content

Inspect macOS DMG before release - #6

Merged
lyc-aon merged 1 commit into
mainfrom
fix/inspect-macos-dmg
Jul 13, 2026
Merged

Inspect macOS DMG before release#6
lyc-aon merged 1 commit into
mainfrom
fix/inspect-macos-dmg

Conversation

@lyc-aon

@lyc-aon lyc-aon commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

What changed

  • mount the built DMG at a unique temporary path with hdiutil attach -readonly -nobrowse -noautoopen
  • locate the single application bundle and run the existing package inspector against its real Contents root
  • detach in cleanup on both success and inspection failure, with a force-detach fallback if the normal detach is busy
  • preserve the mount point and fail the release if detachment cannot complete
  • run DMG inspection before the artifact is staged for publication

Verification

  • pnpm check
  • pnpm test
  • pnpm test:tooling
  • pnpm build:web && pnpm build:desktop
  • pnpm test:packaging — 18 passed
  • native Apple Silicon macOS smoke against the published v0.1.2 DMG — 916 ASAR entries inspected, image detached, no temporary mount left behind

@lyc-aon
lyc-aon merged commit ba2c5a7 into main Jul 13, 2026
1 check passed
@lyc-aon
lyc-aon deleted the fix/inspect-macos-dmg branch July 13, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant