[codex] add private model credential gateway - #147
Merged
Conversation
wolfiesch
marked this pull request as ready for review
July 22, 2026 05:07
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 17f3041263
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
t4-model-gatewayworkload and OCI imageWhy
Cluster sessions expose arbitrary-code tools, so placing reusable provider credentials in the session workload would make them available to user code. The separate gateway preserves model access while reducing the credential-bearing trust boundary to one hardened workload. Exact path allowlisting also prevents the credential from being used against provider account, file, fine-tuning, billing, or other administrative APIs.
Validation
pnpm checkpnpm test:cluster:cipnpm --filter @t4-code/model-gateway testpnpm --filter @t4-code/model-gateway typecheckgo test ./...inpackages/cluster-operatorwith Helm 3.19.0 availablehelm lint deploy/charts/t4-clusterpnpm testruns: all affected suites passed; two unrelated 5-second integration tests intermittently exceeded their timeout under full concurrent load, then passed in isolation (start-electron.test.tsin 4.6 s for all five cases;runtime-workspace-server.test.tsin 5.0 s for all three cases with its established 30-second fixture timeout)No cluster deployment, provider Secret, or production configuration is included in this pull request.