Multi-Window Replay as secondary app #2065
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to using AndroidX which is a major improvement over the previous support libraries for Android. This is going to be needed going forward to use the proper libraries with Gradle since pre-AndroidX libraries are becoming more and more out of date.
Introduce JAVA layer into gfxreconstruct to enable replay multi-window trace files on Android. The command line changes to am start -n "com.lunarg.gfxreconstruct.replay/.ReplayActivity"
Multiwin replay is where we eventually want to go, however it currently does not work well prior to Android 14 due to limitations with changing orientations on high DPI phones. Because of this, we will support both the old "replay" and the new "multiwin-replay" as separate apps which can be triggered by the `gfxrecon.py` script.
|
CI gfxreconstruct build queued with queue ID 391629. |
|
I've extended this with #1912 to include the option to replay using either the old application or your new one. I just have to wait for review, but I will discuss this with @per-mathisen-arm and @bartosz-muszarski-arm in our next meeting. |
|
FYI, @antonio-lunarg , you've already reviewed everything but the last two commits in PR #1912. Mostly, I'd like your feedback on how I handled having both replay applications available (you too @bradgrantham ). |
|
CI gfxreconstruct build # 6293 running. |
|
CI gfxreconstruct build # 6293 passed. |
antonio-lunarg
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply the multi-window replay application from @qiq-2022 to the "dev" tree, but as a secondary replay application instead of replacing the existing replay application.
The reasoning behind this is temporary: the multi-window replay app does not properly handle surface rotations on pre-Android 14 devices. Since we still test such devices in our CI, and end-users are still using pre-Android 14 OS versions, we will support both until Android 14 overtakes the rest of our testing.
For now, you may use the
gfxrecon.pyscript with the argumentreplayto trigger the old replay application andmultiwin-replayto trigger the new multi-window replay application.