Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing StorageClassShaderRecordBufferKHR to spirv-parser #1974

Merged

Conversation

fabian-lunarg
Copy link
Contributor

@fabian-lunarg fabian-lunarg commented Jan 21, 2025

this is relevant for raytracing applications, which use extra data in shader-binding-tables.
-> https://docs.vulkan.org/spec/latest/chapters/raytracing.html#shader-binding-table

this fixes the symptom of spamming Storage class 5343 not handled

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 351787.

@fabian-lunarg fabian-lunarg linked an issue Jan 21, 2025 that may be closed by this pull request
@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5887 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5887 passed.

@fabian-lunarg fabian-lunarg merged commit 566b22d into LunarG:dev Jan 27, 2025
9 checks passed
@fabian-lunarg fabian-lunarg deleted the fabian_fix_missing_spirv_storage_class branch January 27, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SpirV-Parser does not support StorageClassShaderRecordBufferKHR
4 participants