Remove retired swapchain images immediately #1966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation is allowed to destroy and reuse handles for non-acquired swapchain images as soon as the parent swapchain is retired. Update the handle tracking logic to treat these handles as destroyed, so that if they are reused, we don't get collisions in the handle tables. Android is particularly sensitive to this as it will often immediately reuse image handles from retired swapchains, even before the retired swapchain is destroyed.
|
CI gfxreconstruct build queued with queue ID 349703. |
|
CI gfxreconstruct build # 5860 running. |
|
CI gfxreconstruct build # 5860 passed. |
ziga-lunarg
reviewed
Jan 20, 2025
ziga-lunarg
reviewed
Jan 20, 2025
ziga-lunarg
approved these changes
Jan 20, 2025
panos-lunarg
approved these changes
Jan 22, 2025
bradgrantham-lunarg
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation is allowed to destroy and reuse handles for non-acquired swapchain images as soon as the parent swapchain is retired. Update the handle tracking logic to treat these handles as destroyed, so that if they are reused, we don't get collisions in the handle tables.
Android is particularly sensitive to this as it will often immediately reuse image handles from retired swapchains, even before the retired swapchain is destroyed.