Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Portable Acceleration Structures #1955

Merged
merged 26 commits into from
Jan 23, 2025
Merged

Portable Acceleration Structures #1955

merged 26 commits into from
Jan 23, 2025

Conversation

fabian-lunarg
Copy link
Contributor

@fabian-lunarg fabian-lunarg commented Jan 14, 2025 •
edited
Loading

worked mostly on decode::VulkanAddressReplacer,
finally enabling portable replay of raytracing pipelines, when using RebindAllocator (-m rebind).

  • work on Acceleration Structures (AS):
    -> tracking, meta-commands, copies, query-pool handling and rebuild
    -> rebuild AS from original input-buffers when trimming.
    -> check AS- and scratch-buffer sizes, replace resources with shadow objects where required

belongs to #1526

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 344454.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5784 running.

@fabian-lunarg fabian-lunarg force-pushed the fabian_portable_acceleration_structures branch from 154df0e to c08661a Compare January 14, 2025 09:38
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 344470.

@fabian-lunarg fabian-lunarg force-pushed the fabian_portable_acceleration_structures branch from c08661a to c810c23 Compare January 14, 2025 09:42
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 344472.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5785 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5785 failed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 344525.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5787 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5787 failed.

@fabian-lunarg fabian-lunarg force-pushed the fabian_portable_acceleration_structures branch from c810c23 to 62d9748 Compare January 14, 2025 13:05
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 344589.

@fabian-lunarg fabian-lunarg force-pushed the fabian_portable_acceleration_structures branch from 62d9748 to 16e5877 Compare January 14, 2025 13:07
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 344604.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5789 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 344693.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5790 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5790 failed.

antonio-lunarg
antonio-lunarg reviewed Jan 14, 2025
View reviewed changes
framework/decode/vulkan_address_replacer.h Show resolved Hide resolved
framework/decode/vulkan_address_replacer.h Outdated Show resolved Hide resolved
framework/decode/vulkan_address_replacer.cpp Outdated Show resolved Hide resolved
framework/decode/vulkan_address_replacer.cpp Outdated Show resolved Hide resolved
framework/decode/vulkan_address_replacer.cpp Outdated Show resolved Hide resolved
framework/decode/vulkan_address_replacer.cpp Show resolved Hide resolved
framework/decode/vulkan_address_replacer.cpp Outdated Show resolved Hide resolved
framework/decode/vulkan_device_address_tracker.cpp Outdated Show resolved Hide resolved
framework/decode/vulkan_device_address_tracker.cpp Outdated Show resolved Hide resolved
framework/decode/vulkan_rebind_allocator.cpp Outdated Show resolved Hide resolved
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 345010.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5796 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5796 failed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 345554.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5801 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5801 failed.

@fabian-lunarg
Process meta-commands (rebuild AS when trimming)
f661b0a
@fabian-lunarg
Implement ProcessBuildVulkanAccelerationStructuresMetaCommand.
31c6b89 
- Add internal command/queue-assets, manage lifetime
@fabian-lunarg
Add missing tracking of AS scratch-buffers, needed for trimming
52a48f6
@fabian-lunarg
Drop instance_buffers_data, cleanup, doc
b8170af
@fabian-lunarg
Seperate AS- and scratch shadow-objects, minor improvements
3969f33
@fabian-lunarg
Add VulkanCaptureManager::OverrideCmdCopyAccelerationStructureKHR
d967730
@fabian-lunarg
work on ProcessVulkanAccelerationStructuresWritePropertiesMetaCommand
ba3e802
@fabian-lunarg
Overall progress and cleanup. some open things, but slowly finalizing
59300ac
@fabian-lunarg
bring back opaque shadergroup-handles, you never know
ca92462
@fabian-lunarg
compute-shaders compiled against vulkan1.1 + optimized spirv
16d5964
@fabian-lunarg
Guard address_replacer.ProcessCmdTraceRays(), only for '-m rebind'
64843cc 
- cleanup obsolete warnings
@fabian-lunarg
review comments, cleanup
7dfe3e5
@fabian-lunarg
Extend state-tracking for VkPhysicalDeviceAccelerationStructureProper…
414a0bc 
…tiesKHR
@fabian-lunarg
Fetch VkPhysicalDeviceAccelerationStructurePropertiesKHR, in case nob…
a6d0117 
…ody else did
@fabian-lunarg
Consolidate alignment utils in dedicated header
86b6e1b
@fabian-lunarg
Repeat call to SetRaytracingProperties, if necessary. we might have m…
8f9c77a 
…iss it during init
@fabian-lunarg
simpler API for SetRaytracingProperties
1778128
@fabian-lunarg
Minor fixes and corrections
85bde2b
@fabian-lunarg
Add missing vkCmdResetQueryPool before running internal queries
bb7c379
@fabian-lunarg
remove a duplicated VkMemoryPropertyFlags, minor correction in doc-st…
26d7ca3 
…ring
@fabian-lunarg fabian-lunarg force-pushed the fabian_portable_acceleration_structures branch from ae566e6 to 26d7ca3 Compare January 22, 2025 07:55
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 352580.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5893 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5893 passed.

@fabian-lunarg fabian-lunarg merged commit b226fe2 into LunarG:dev Jan 23, 2025
9 checks passed
bradgrantham-lunarg pushed a commit to bradgrantham-lunarg/gfxreconstruct that referenced this pull request Jan 24, 2025
@fabian-lunarg @bradgrantham-lunarg
Portable Acceleration Structures (LunarG#1955)
58c9a6d 
- worked mostly on decode::VulkanAddressReplacer
- enables portable replay of raytracing pipelines, when using RebindAllocator (-m rebind).
- work on Acceleration Structures (AS):
-> tracking, meta-commands, copies, query-pool handling and rebuild
-> rebuild AS from original input-buffers when trimming.
-> check AS- and scratch-buffer sizes, replace resources with shadow objects where required
@fabian-lunarg fabian-lunarg deleted the fabian_portable_acceleration_structures branch January 30, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonio-lunarg antonio-lunarg antonio-lunarg approved these changes

@bradgrantham-lunarg bradgrantham-lunarg bradgrantham-lunarg approved these changes

@MarkY-LunarG MarkY-LunarG MarkY-LunarG approved these changes

@nickdriscoll-lunarg nickdriscoll-lunarg Awaiting requested review from nickdriscoll-lunarg

Assignees

@fabian-lunarg fabian-lunarg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fabian-lunarg @ci-tester-lunarg @MarkY-LunarG @bradgrantham-lunarg @antonio-lunarg