Vulkan codegen refactor tranche 4 #1950
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzulauf-lunarg
requested review from
MarkY-LunarG,
bradgrantham-lunarg and
fabian-lunarg
|
CI gfxreconstruct build queued with queue ID 344024. |
|
CI gfxreconstruct build # 5779 running. |
|
CI gfxreconstruct build # 5779 passed. |
Update the referenced resource consumer generators to use the Khronos variables. Interestingly enough, it removes 4 functions which appeared to have incorrectly been added by the previous codegen.
Update the command buffer util header codegen to remove unused types and use Khronos types when necessary.
Remove unused types and use Khronos types.
Update the api call encoder body generation to use Khronos types.
Now that the porting is done, rename "global_structs_with_handle" with "structs_with_handle".
Update the struct handle wrapper header generation to move a majority of the code into the Khronos folder as it is mostly API agnostic.
Use "isHandleLike" when determining if we need to treat a type like a handle, atom, or opaque type.
Move the structure handle wrapping body code generation to the Khronos version except for special cases.
This actually exposed a bug where we were incorrectly handling an Arm flag type.
We had 2 global methods that could be incorporated directly into the Khronos base class in a cleaner way. These were removed: BitsEnumToFlagsTypedef, removeSuffix
jzulauf-lunarg
force-pushed
the
zulauf-vulkan-codegen-checkpoint-4
branch
from
542ed04 to
1e74722
Compare
|
CI gfxreconstruct build queued with queue ID 352934. |
|
CI gfxreconstruct build # 5900 running. |
|
CI gfxreconstruct build # 5900 passed. |
| template <> std::string ToString<VkPhysicalDeviceSchedulingControlsFlagBitsARM>(const VkPhysicalDeviceSchedulingControlsFlagBitsARM& value, ToStringFlags toStringFlags, uint32_t tabCount, uint32_t tabSize); | ||
| template <> std::string ToString<VkPhysicalDeviceSchedulingControlsFlagBitsARM>(VkFlags vkFlags, ToStringFlags toStringFlags, uint32_t tabCount, uint32_t tabSize); | ||
| std::string VkPhysicalDeviceSchedulingControlsFlagBitsARMToString(const VkPhysicalDeviceSchedulingControlsFlagBitsARM value); | ||
| std::string VkPhysicalDeviceSchedulingControlsFlagsARMToString(VkFlags64 vkFlags); |
There was a problem hiding this comment.
why change the signature for those 2 functions?
another remark, not very important:
the header 'could' be left out from codegen, only define:
template <typename T> std::string ToString<T>(const T& value, ToStringFlags toStringFlags, uint32_t tabCount, uint32_t tabSize) = delete;
codegen would then only need to generate the .cpp
and the header could be manually edited and the API documented.
There was a problem hiding this comment.
ok nevermind. I see the header already contained other, non-templated helpers
fabian-lunarg
approved these changes
Jan 27, 2025
bradgrantham-lunarg
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another 30 commit branch roughly