Fix crash in vkBeginCommandBuffer #1922
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI gfxreconstruct build queued with queue ID 326099. |
ziga-lunarg
commented
Dec 17, 2024
| @@ -284,6 +284,17 @@ def make_cmd_body(self, return_type, name, values): | |||
|
|
|||
| body += '\n' | |||
|
|
|||
| if name == 'vkBeginCommandBuffer': | |||
There was a problem hiding this comment.
I don't know if there is a better place to put this generated code
There was a problem hiding this comment.
I would vote for creating an override function and handle it there
|
CI gfxreconstruct build # 5566 running. |
|
CI gfxreconstruct build # 5566 failed. |
|
CI gfxreconstruct build queued with queue ID 326150. |
|
CI gfxreconstruct build # 5567 running. |
|
CI gfxreconstruct build # 5567 failed. |
|
This PR needs resolution of the failed CI Jenkins run test cases and deciding whether Panos' suggestion to move this to an override function is appropriate, is that right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the spec:
This would crash if pInheritanceInfo is pointing to invalid memory.