Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External memory FD #1913

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

External memory FD #1913

wants to merge 4 commits into from
+938 −282

Conversation

antonio-lunarg
Copy link
Contributor

@antonio-lunarg antonio-lunarg commented Dec 12, 2024 •
edited
Loading

Initial support for VK_KHR_external_memory_fd.

Capture: once a device memory imported from external FD is bound to a buffer, an InitBuffer command is generated with the current content of the memory.

Replay: the import memory FD structure is removed from the pNext chain of VkMemoryAllocateInfo, and the initial content of the buffer is initialized through the InitBuffer command.

@antonio-lunarg antonio-lunarg self-assigned this Dec 12, 2024
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 322697.

@antonio-lunarg antonio-lunarg marked this pull request as draft December 12, 2024 10:39
@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5541 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5541 failed.

@antonio-lunarg antonio-lunarg force-pushed the antonio-external-memory-fd branch from 95eda51 to eb82b6b Compare December 12, 2024 16:05
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 323029.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5546 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5546 failed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 323117.

@antonio-lunarg antonio-lunarg force-pushed the antonio-external-memory-fd branch from 71d4473 to 967717c Compare December 12, 2024 17:58
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 323118.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5551 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5551 failed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 325414.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5563 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5563 failed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 326755.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5581 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5581 failed.

@antonio-lunarg antonio-lunarg force-pushed the antonio-external-memory-fd branch from 7fbfacb to 7ddf396 Compare December 19, 2024 13:40
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 327692.

@antonio-lunarg antonio-lunarg force-pushed the antonio-external-memory-fd branch from 7ddf396 to 934034a Compare December 19, 2024 13:48
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 327694.

@antonio-lunarg antonio-lunarg force-pushed the antonio-external-memory-fd branch from 934034a to b473716 Compare December 19, 2024 13:50
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 327696.

@antonio-lunarg antonio-lunarg force-pushed the antonio-external-memory-fd branch from b473716 to abf54c2 Compare December 19, 2024 15:23
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 327761.

@antonio-lunarg antonio-lunarg force-pushed the antonio-external-memory-fd branch from 5e20ad0 to a9915e4 Compare December 20, 2024 15:18
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 328954.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5635 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5635 failed.

fabian-lunarg
fabian-lunarg reviewed Jan 6, 2025
View reviewed changes
framework/graphics/vulkan_struct_get_pnext.h
* @return a typed pointer to a structure removed from the pNext-chain or nullptr.
*/
template <typename T, typename Parent_T>
static T* vulkan_struct_remove_pnext(Parent_T* parent)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :)

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 339311.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5701 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5701 failed.

antonio-lunarg and others added 3 commits January 8, 2025 11:01
@antonio-lunarg
decode: Do not import fd on replay
071347f
@antonio-lunarg
encode: Init buffer after binding external memory
cbabb50
@MarkY-LunarG @antonio-lunarg
Remove consumer replay usage of external FD items
8d1633c 
During replay, there is no external memory, so we want to strip out
the external memory items for replay.

Co-authored-by: Antonio Caggiano <[email protected]>
@antonio-lunarg antonio-lunarg force-pushed the antonio-external-memory-fd branch from 4604681 to 18bcbe3 Compare January 8, 2025 10:31
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 339960.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5718 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5718 failed.

@antonio-lunarg antonio-lunarg force-pushed the antonio-external-memory-fd branch from 18bcbe3 to ef1d8c6 Compare January 8, 2025 11:27
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 339986.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5719 running.

@antonio-lunarg antonio-lunarg force-pushed the antonio-external-memory-fd branch from ef1d8c6 to b49fcd9 Compare January 8, 2025 11:33
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 340001.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5720 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5720 failed.

@antonio-lunarg antonio-lunarg force-pushed the antonio-external-memory-fd branch from b49fcd9 to 3f29903 Compare January 8, 2025 11:55
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 340036.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5722 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5722 failed.

@antonio-lunarg
encode: OutputStreamWriter and CommandWriter
496a8fc 
Introduce two new classes to extract some common code.

The OutputStreamWriter is inherited by both the capture manager and the
state tracker and provides common utilities for writing to an output
stream.

The CommandWriter is an encode utility for writing commands to an
outpust stream and it is used by both the capture manager and the state
tracker.
@antonio-lunarg antonio-lunarg force-pushed the antonio-external-memory-fd branch from 3f29903 to 496a8fc Compare January 8, 2025 12:52
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 340063.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5723 running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabian-lunarg fabian-lunarg fabian-lunarg left review comments

@MarkY-LunarG MarkY-LunarG MarkY-LunarG left review comments

@bradgrantham-lunarg bradgrantham-lunarg Awaiting requested review from bradgrantham-lunarg

@ziga-lunarg ziga-lunarg Awaiting requested review from ziga-lunarg

@panos-lunarg panos-lunarg Awaiting requested review from panos-lunarg

Assignees

@antonio-lunarg antonio-lunarg

Labels
vulkan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@antonio-lunarg @ci-tester-lunarg @MarkY-LunarG @fabian-lunarg