Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax VulkanStateWriter's IsMemoryReadable() criteria #1872

Closed
wants to merge 1 commit into from
Closed

Relax VulkanStateWriter's IsMemoryReadable() criteria #1872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions framework/decode/vulkan_replay_consumer_base.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -923,9 +923,8 @@ void VulkanReplayConsumerBase::ProcessInitImageCommand(format::HandleId
if (data_size > 0)
{
if ((image_info->tiling == VK_IMAGE_TILING_LINEAR) &&
(image_info->memory_property_flags &
(VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT | VK_MEMORY_PROPERTY_HOST_CACHED_BIT)) ==
(VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT | VK_MEMORY_PROPERTY_HOST_CACHED_BIT))
(image_info->memory_property_flags & VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT) ==
VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT)
{
result = initializer->LoadData(data_size, data, image_info->allocator_data);

Expand Down
3 changes: 1 addition & 2 deletions framework/encode/vulkan_state_writer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,7 @@ static bool IsMemoryCoherent(VkMemoryPropertyFlags property_flags)

static bool IsMemoryReadable(VkMemoryPropertyFlags property_flags)
{
return ((property_flags & (VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT | VK_MEMORY_PROPERTY_HOST_CACHED_BIT)) ==
(VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT | VK_MEMORY_PROPERTY_HOST_CACHED_BIT));
return ((property_flags & VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT) == VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT);
}

static bool IsBufferReadable(VkMemoryPropertyFlags property_flags,
Expand Down
Loading