Fix crash when window cannot be opened with same resolution #1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI gfxreconstruct build queued with queue ID 193157. |
|
CI gfxreconstruct build # 4244 running. |
|
CI gfxreconstruct build # 4244 passed. |
marius-pelegrin-arm
force-pushed
the
fix-759
branch
from
72a8ce9 to
b12410f
Compare
|
CI gfxreconstruct build queued with queue ID 193177. |
|
CI gfxreconstruct build # 4245 running. |
|
CI gfxreconstruct build # 4245 passed. |
marius-pelegrin-arm
force-pushed
the
fix-759
branch
from
b12410f to
7f25041
Compare
|
CI gfxreconstruct build queued with queue ID 198148. |
|
CI gfxreconstruct build # 4262 running. |
|
CI gfxreconstruct build # 4262 passed. |
bradgrantham-lunarg
added
P1
|
Rebasing this on the latest tree. I'll be overwritting your tree. |
Fix a crash on VK_ERROR_OUT_OF_DATE_KHR when the window of the replayer cannot be resized to the size of the swapchain at capture time and that the replayer uses virtual swapchain. The idea is to store the actual size of the window that could be opened at replay time in the virtual swapchain so that the virtual swapchain has the same size as at capture time, and the actual swapchain is the size of the window. When the image is copied from the virtual image to the actual image, only a sub-part of the image is copied. Change-Id: I9609fc524b0faf0f6aed3f1efe570fc5fed86225
Fix a crash on VK_ERROR_OUT_OF_DATE_KHR when the window of the replayer cannot be resized to the size of the swapchain at capture time and that the replayer uses virtual swapchain. The idea is to store the actual size of the window that could be opened at replay time in the virtual swapchain so that the virtual swapchain has the same size as at capture time, and the actual swapchain is the size of the window. When the image is copied from the virtual image to the actual image, only a sub-part of the image is copied. Change-Id: I9609fc524b0faf0f6aed3f1efe570fc5fed86225
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit partially fix issue #759
Fix a crash on
VK_ERROR_OUT_OF_DATE_KHRwhen the window of the replayer cannot be resized to the size of the swapchain at capture time and that the replayer uses virtual swapchain.The idea is to store the actual size of the window that could be opened at replay time in the virtual swapchain so that the virtual swapchain has the same size as at capture time, and the actual swapchain is the size of the window. When the image is copied from the virtual image to the actual image, only a sub-part of the image is copied.