Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support AGS 6.2.0 #1439

Merged
merged 2 commits into from
Mar 12, 2024
Merged

support AGS 6.2.0 #1439

merged 2 commits into from
Mar 12, 2024

Conversation

igorbrsn
Copy link
Contributor

@igorbrsn igorbrsn commented Mar 5, 2024

The problem
New AGS 6.2 version support is not supported.

The solution
6.2 changes are:

added shaderClock.
warning in capture if major version is not supported.
replay warning message if version is not 6.2.0.
backward compatibility supported - we still can replay 6.0.1 captures. We also can capture and replay 6.0.1 version.
ags.lib and agsd.lib updated to 6.2.0

Result
Based on my testing I was able to capture and replay both Full and Trimmed version of 6.2 and 6.0 AGS

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 145033.

@CLAassistant
Copy link

CLAassistant commented Mar 5, 2024

CLA assistant check
All committers have signed the CLA.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3815 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3815 failed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 145614.

@lunarpapillo
Copy link
Contributor

CI failure seems to be due to a busy machine. Re-running.

framework/encode/d3d12_capture_manager.h Outdated Show resolved Hide resolved
framework/encode/custom_ags_wrappers.cpp Outdated Show resolved Hide resolved
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 145640.

@igorbrsn igorbrsn force-pushed the dev-support-ags6.2.0 branch from 92909b9 to 17fa972 Compare March 6, 2024 18:25
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 145647.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3821 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3821 passed.

@davidd-lunarg davidd-lunarg self-assigned this Mar 11, 2024
@igorbrsn igorbrsn force-pushed the dev-support-ags6.2.0 branch from 17fa972 to a5ee76a Compare March 12, 2024 17:43
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 149144.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 149170.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3858 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3858 passed.

@davidd-lunarg davidd-lunarg merged commit d7127d4 into LunarG:dev Mar 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants