Remove duplicate line in .clang-format #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cases newer versions of clang-format to fail to format the file.
|
CI gfxreconstruct build queued with queue ID 143114. |
|
CI gfxreconstruct build # 3802 running. |
|
CI gfxreconstruct build # 3802 passed. |
|
|
Wait if true means all does that mean this change would alter the format of files? I don’t want to check this in and break subsequent pr’s due to wrong formatting. |
|
I don't think so; you're deleting the first instance of the directive which is (I think) in older clang-formats replaced by the later directive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cases newer versions of clang-format to fail to format the file.