Fix swapchain image wrappers lifetime #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an application creates multiple swapchains, the images retrieved with vkGetSwapchainImages() can be the same for different swapchains. The parents of swapchain images were not tracked and when one swapchain was destroyed the swapchain image wrappers were as well, even though another swapchain might still be using them
|
CI gfxreconstruct build queued with queue ID 134561. |
|
|
|
CI gfxreconstruct build # 3735 running. |
|
CI gfxreconstruct build # 3735 passed. |
|
@davidlunarg has a draft PR #1304 to fix a swapchain issue for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an application creates multiple swapchains, the images retrieved with vkGetSwapchainImages() can be the same for different swapchains. The parents of swapchain images were not tracked and when one swapchain was destroyed the swapchain image wrappers were as well, even though another swapchain might still be using them