Fix trim raytracing invalid device issue #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trim raytracing handling use map_device of memory object wrapper which is not initialized, the error make some title run into crash with GFXR trim capturing. The commit fixed the issue.
Add some changes to address code review comments.
|
CI gfxreconstruct build queued with queue ID 125734. |
|
CI gfxreconstruct build # 3715 running. |
|
CI gfxreconstruct build # 3715 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
Trim raytracing handling use a device field of memory object wrapper which is not initialized, the error makes some title run into crash with GFXR trim capturing.
The solution
The fix is adding a CreateWrappedHandle template function for VkDeviceMemory which initialize the field in allocation of the Vulkan memory object.
Result
Tested target title with the build of the pull request, it fixed the issue.