resolve an overridden function with different signature #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI gfxreconstruct build queued with queue ID 123328. |
|
CI gfxreconstruct build queued with queue ID 123350. |
|
CI gfxreconstruct build # 3707 running. |
|
CI gfxreconstruct build # 3707 passed. |
bradgrantham-lunarg
requested review from
davidlunarg
and removed request for
davidd-lunarg
bradgrantham-lunarg
requested review from
davidlunarg
and removed request for
davidlunarg
bradgrantham-lunarg
requested review from
yaman-lunarg
and removed request for
davidlunarg
yaman-lunarg
approved these changes
Mar 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With full warnings enabled on macOS I saw an error with
OutputStream::Reset()being shadowed byFileOutputStream::Reset(FILE*). Resolve this shadow by changing the name of Reset forMemoryOutputStreamtoClear(to match C++ container method names), remove the base classReset, and makeFileOutputStream::Resetnot be an override.