Fix forgotten handles in VulkanStateWriter #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some handle types are not correctly handled at fast forwarding time. This cause strange artifacts, for example when fast-forwarding Sascha Willem's 'pushdescriptors'. Change-Id: I860f8899507198326a736198ee3b62e444416786
|
CI gfxreconstruct build queued with queue ID 99656. |
|
CI gfxreconstruct build # 3615 running. |
|
CI gfxreconstruct build # 3615 failed. |
|
LunarG CI failure seems to be due to GPU crash. Restarting. |
|
CI gfxreconstruct build queued with queue ID 99819. |
|
CI gfxreconstruct build # 3616 running. |
|
CI gfxreconstruct build # 3616 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some handle types are not correctly handled at fast forwarding time, in particular some switch cases are missing in
VulkanStateWriter::CheckCommandHandle. This causes strange artifacts, for example when fast-forwarding Sascha Willem'spushdescriptorssample.