Fix pNext chains unproperly copied in VulkanStateTracker (Issue #1269)
#1363
Conversation
|
CI gfxreconstruct build queued with queue ID 87259. |
|
CI gfxreconstruct build # 3533 running. |
|
CI gfxreconstruct build # 3533 passed. |
|
Haven't reviewed the code at all, but at first glance this is the same concept as the 'safe structs' in Vulkan-ValidationLayers. I previously considered moving the safe structs codegen from validation layers over to the Vulkan-Utility-Libraries, but dismissed it as just needless moving of code. But seeing that the same need appears in gfxreconstruct, that makes it clear that its useful for more than just validation layers. Definitely not a priority, but good to know that many repositories could take advantages of a "safe struct" utility library. |
|
My initial code review says that this change is good, and running it through vulkaninfo didn't find any problems. That said, I haven't tried using the repro case and would like to give that a whirl before any final approvals. |
This commit fixes the issue LunarG#1269 The first idea was to modify the `UnwrapStruct*Handles` functions to allow more flexibility on what is unwrapped (Vulkan handles, application owned pointers or both). But I couldn't find a way to properly modify these functions without either altering their behavior, their performance, or having to dig into deeper changes. So instead, this commit simply add two new generated files, `generated_vulkan_struct_trackers` header and body. The idea is to implement a function `TrackStruct` and its overload over all Vulkan structs, that deep-copy the structs by also copying application owned dynamically allocated memory. This way, the copy returned by `TrackStruct` can be kept indefinitely without undefined behavior, and not just in the time of a call. All the other file changes are to integrate this new call. Change-Id: I25f4408d7d7a8a5f4a3d962f8951672129e88647
MarkY-LunarG
force-pushed
the
fix-1269
branch
from
e3f0197 to
a40ccd6
Compare
|
CI gfxreconstruct build queued with queue ID 125116. |
|
CI gfxreconstruct build # 3712 running. |
|
Verified that this did fix the issue with the repro case I have. |
|
CI gfxreconstruct build # 3712 passed. |
bradgrantham-lunarg
assigned MarkY-LunarG and charles-lunarg and unassigned charles-lunarg and MarkY-LunarG
This commit fixes the issue #1269
The first idea was to modify the
UnwrapStruct*Handlesfunctions to allow more flexibility on what is unwrapped (Vulkan handles, application owned pointers or both).But I couldn't find a way to properly modify these functions without either altering their behavior, their performance, or having to dig into deeper fundamental changes.
So instead, this commit simply add two new generated files,
generated_vulkan_struct_trackersheader and body.The idea is to implement a function
TrackStructand its overload over all Vulkan structs, that deep-copy the structs by also copying application owned dynamically allocated memory.This way, the copy returned by
TrackStructcan be kept indefinitely without undefined behavior, and not just in the time of a call.All the other file changes are to integrate this new call.