Added Frame Range Option to Convert Tool #1295
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI gfxreconstruct build queued with queue ID 56820. |
tools/convert/main.cpp
Outdated
| @@ -72,6 +72,9 @@ static void PrintUsage(const char* exe_name) | |||
| GFXRECON_WRITE_CONSOLE( | |||
| " --file-per-frame\tCreates a new file for every frame processed. Frame number is added as a suffix"); | |||
| GFXRECON_WRITE_CONSOLE(" \tto the output file name."); | |||
| GFXRECON_WRITE_CONSOLE( | |||
| " --frame-range\t\tFrame range to be converted. In order to retrieve Trim Trace State, frame 0 has " | |||
| "to be in frame range."); | |||
There was a problem hiding this comment.
It would be good to tell the user the format for specifying the frame range here.
There was a problem hiding this comment.
I have updated the help message to:
--frame-range <N1[-N2][,...]>
Frame ranges to be converted. In order to retrieve trim trace state, frame 0 has to be in frame range.
Frame ranges should be specified in ascending order and cannot overlap. Frame numbering is zero-indexed and inclusive.
Example: 0-2,5,8-10 will generate data for 7 frames.
|
CI gfxreconstruct build queued with queue ID 56850. |
|
CI gfxreconstruct build # 3347 passed. |
|
CI gfxreconstruct build queued with queue ID 69624. |
|
CI gfxreconstruct build # 3415 running. |
|
CI gfxreconstruct build # 3415 failed. |
bradgrantham-lunarg
added
the
P2
laurentiu-erhan-arm
force-pushed
the
convertFrameRangeSupport
branch
from
41d0698 to
fc1baa4
Compare
|
CI gfxreconstruct build queued with queue ID 100998. |
|
CI gfxreconstruct build # 3625 running. |
|
CI gfxreconstruct build # 3625 passed. |
Frame range option allows to only retrieve relevant data and reduce waiting time, especially useful for bigger traces Change-Id: I3b7298a20c41d2c67a59069ddf31961f37a3b12d
laurentiu-erhan-arm
force-pushed
the
convertFrameRangeSupport
branch
from
fc1baa4 to
ebaf99e
Compare
|
CI gfxreconstruct build queued with queue ID 181553. |
|
CI gfxreconstruct build # 4125 running. |
|
CI gfxreconstruct build # 4125 failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frame range option allows to only retrieve relevant data and reduce waiting time, especially useful for bigger traces
Change-Id: I3b7298a20c41d2c67a59069ddf31961f37a3b12d