Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --flush-inside-measurement-range option #1213

Merged

Conversation

marius-pelegrin-arm
Copy link
Contributor

Add option to flush and wait all current GPU work to finish at the end of every frame inside the measurement range.

This allows to take measurements on each frame individually without jobs interleaving between two frames.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 12229.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3023 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3023 passed.

@bradgrantham-lunarg bradgrantham-lunarg added the P2 A high-priority code maintenance issue or a functional problem that is recoverable or not a crash. label Oct 30, 2023
@marius-pelegrin-arm marius-pelegrin-arm force-pushed the flush-inside-measurement-range branch from 3946108 to 3c701e5 Compare January 26, 2024 08:19
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 122830.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3697 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3697 passed.

marius-pelegrin-arm and others added 2 commits February 9, 2024 12:13
Add option to flush and wait all current GPU work to finish
at the end of every frame inside the measurement range.

This allows to take measurements on each frame individually
without jobs interleaving between two frames.

Change-Id: I5e55fcfc33c4baa344445a963fedbe80e94c925c
Update the usage and replay scripts to support the new
--flush-inside-measurement-range option.
@MarkY-LunarG MarkY-LunarG force-pushed the flush-inside-measurement-range branch from 3c701e5 to dc9834d Compare February 9, 2024 20:33
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 131347.

Copy link
Contributor

@MarkY-LunarG MarkY-LunarG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I just added another commit to add to the documentation as well as support for the script.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3728 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3728 aborted.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 133047.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3731 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3731 passed.

@MarkY-LunarG MarkY-LunarG merged commit 3ac271f into LunarG:dev Feb 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 A high-priority code maintenance issue or a functional problem that is recoverable or not a crash.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants