Skip to content

Commit

Permalink
Fixed Linking disable_popup_result for all Tools
Browse files Browse the repository at this point in the history
Previously each tool's CMakeLists.txt was restating the linkage for
the replay tool.
  • Loading branch information
andrew-lunarg committed Jul 14, 2023
1 parent 5884ad2 commit 7f60dc4
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions tools/compress/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@ if (MSVC)
# Force inclusion of "gfxrecon_disable_popup_result" variable in linking.
# On 32-bit windows, MSVC prefixes symbols with "_" but on 64-bit windows it doesn't.
if(CMAKE_SIZEOF_VOID_P EQUAL 4)
target_link_options(gfxrecon-replay PUBLIC "LINKER:/Include:_gfxrecon_disable_popup_result")
target_link_options(gfxrecon-compress PUBLIC "LINKER:/Include:_gfxrecon_disable_popup_result")
else()
target_link_options(gfxrecon-replay PUBLIC "LINKER:/Include:gfxrecon_disable_popup_result")
target_link_options(gfxrecon-compress PUBLIC "LINKER:/Include:gfxrecon_disable_popup_result")
endif()
endif()

Expand Down
4 changes: 2 additions & 2 deletions tools/convert/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ if (MSVC)
# Force inclusion of "gfxrecon_disable_popup_result" variable in linking.
# On 32-bit windows, MSVC prefixes symbols with "_" but on 64-bit windows it doesn't.
if(CMAKE_SIZEOF_VOID_P EQUAL 4)
target_link_options(gfxrecon-replay PUBLIC "LINKER:/Include:_gfxrecon_disable_popup_result")
target_link_options(gfxrecon-convert PUBLIC "LINKER:/Include:_gfxrecon_disable_popup_result")
else()
target_link_options(gfxrecon-replay PUBLIC "LINKER:/Include:gfxrecon_disable_popup_result")
target_link_options(gfxrecon-convert PUBLIC "LINKER:/Include:gfxrecon_disable_popup_result")
endif()
endif()

Expand Down
4 changes: 2 additions & 2 deletions tools/extract/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ if (MSVC)
# Force inclusion of "gfxrecon_disable_popup_result" variable in linking.
# On 32-bit windows, MSVC prefixes symbols with "_" but on 64-bit windows it doesn't.
if(CMAKE_SIZEOF_VOID_P EQUAL 4)
target_link_options(gfxrecon-replay PUBLIC "LINKER:/Include:_gfxrecon_disable_popup_result")
target_link_options(gfxrecon-extract PUBLIC "LINKER:/Include:_gfxrecon_disable_popup_result")
else()
target_link_options(gfxrecon-replay PUBLIC "LINKER:/Include:gfxrecon_disable_popup_result")
target_link_options(gfxrecon-extract PUBLIC "LINKER:/Include:gfxrecon_disable_popup_result")
endif()
endif()

Expand Down
4 changes: 2 additions & 2 deletions tools/info/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ if (MSVC)
# Force inclusion of "gfxrecon_disable_popup_result" variable in linking.
# On 32-bit windows, MSVC prefixes symbols with "_" but on 64-bit windows it doesn't.
if(CMAKE_SIZEOF_VOID_P EQUAL 4)
target_link_options(gfxrecon-replay PUBLIC "LINKER:/Include:_gfxrecon_disable_popup_result")
target_link_options(gfxrecon-info PUBLIC "LINKER:/Include:_gfxrecon_disable_popup_result")
else()
target_link_options(gfxrecon-replay PUBLIC "LINKER:/Include:gfxrecon_disable_popup_result")
target_link_options(gfxrecon-info PUBLIC "LINKER:/Include:gfxrecon_disable_popup_result")
endif()
endif()

Expand Down
4 changes: 2 additions & 2 deletions tools/optimize/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,9 @@ if (MSVC)
# Force inclusion of "gfxrecon_disable_popup_result" variable in linking.
# On 32-bit windows, MSVC prefixes symbols with "_" but on 64-bit windows it doesn't.
if(CMAKE_SIZEOF_VOID_P EQUAL 4)
target_link_options(gfxrecon-replay PUBLIC "LINKER:/Include:_gfxrecon_disable_popup_result")
target_link_options(gfxrecon-optimize PUBLIC "LINKER:/Include:_gfxrecon_disable_popup_result")
else()
target_link_options(gfxrecon-replay PUBLIC "LINKER:/Include:gfxrecon_disable_popup_result")
target_link_options(gfxrecon-optimize PUBLIC "LINKER:/Include:gfxrecon_disable_popup_result")
endif()
endif()

Expand Down

0 comments on commit 7f60dc4

Please sign in to comment.