fix: Missing default props on sdk request, when option prop passed#47
Open
SirSerje wants to merge 2 commits intoLuehang:masterfrom
Open
fix: Missing default props on sdk request, when option prop passed#47SirSerje wants to merge 2 commits intoLuehang:masterfrom
SirSerje wants to merge 2 commits intoLuehang:masterfrom
Conversation
SirSerje
changed the title
romanmtb
suggested changes
Dec 23, 2019
romanmtb
left a comment
romanmtb
left a comment
There was a problem hiding this comment.
eslint also broken, update it, if possible:
.eslintignore : src/tests/*
package.json : "lint": "./node_modules/.bin/eslint src/** example/**",
SirSerje
changed the title
romanmtb
approved these changes
Dec 23, 2019
|
Hey can this get merge in ? |
Author
I think, yes, this PR does not break any other logic of the lib |
Author
I think to fork this repo is the best option for you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for #46
You can pass both default props, of course, but it's not clear for newcomers to lib
Please, review and give some comments