fix: resolve 4 Windows compatibility bugs in installer and CLI#26
Open
alipiomg wants to merge 1 commit intoLucasHJin:mainfrom
Open
fix: resolve 4 Windows compatibility bugs in installer and CLI#26alipiomg wants to merge 1 commit intoLucasHJin:mainfrom
alipiomg wants to merge 1 commit intoLucasHJin:mainfrom
Conversation
1. Wrap python3 version check in try/catch to handle Windows Store redirect alias that causes a terminating error with ErrorActionPreference=Stop 2. Prefer python module over vit.exe for Resolve script installation, since unsigned pip-generated exe is blocked by Windows Defender 3. Replace em dash (U+2014) with ASCII -- to prevent UTF-8 parse failures in PowerShell without BOM 4. Replace Unicode arrows (U+2192) in print statements with ASCII -> to fix UnicodeEncodeError on cp1252 Windows consoles Fixes LucasHJin#25 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 4 bugs that prevent clean installation on Windows (PowerShell 5.1, Python 3.12, Windows 11):
try/catchso the Windows Store redirect forpython3.exedoesn't cause a fatal error beforepythonis triedpython -m vit.cliover the unsignedvit.exefor Resolve script installation—(U+2014) with--to prevent PowerShell parse failures on files without BOM→(U+2192) with->inprint()calls to fixUnicodeEncodeErroron cp1252 consolesTest plan
irm .../install.ps1 | iexon a clean Windows 11 machine with Python from python.orgpython3Store alias is skipped gracefully andpythonis usedvit install-resolvesucceeds via python moduleFixes #25
🤖 Generated with Claude Code