Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BaseStatusListFragment): save scroll position when adding quote #463

Closed
wants to merge 1 commit into from

Conversation

FineFindus
Copy link

Partially fixes an issue, where the recylcerview would be reset back to the top when adding a quote. With this it only lags/stutters. A full fix would be better, but I honestly have no idea how to.

Partially fixes an issue, where the recylcerview would be reset back to
the top when adding a quote. With this it only lags/stutters.
@LucasGGamerM
Copy link
Owner

I think this is not optional, as it will jump whenever a new quote it added. Maybe a check would be nicer here

@FineFindus
Copy link
Author

as it will jump whenever a new quote it added

Yes, that's the point of it, though the jump is only noticeable as a small lag. I'm not quite sure what you mean by adding a check?

@LucasGGamerM
Copy link
Owner

as it will jump whenever a new quote it added

Yes, that's the point of it, though the jump is only noticeable as a small lag. I'm not quite sure what you mean by adding a check?

It is to check if the position changed to zero, then we would go back to the position.

@FineFindus
Copy link
Author

That wouldn't matter, since it will always reset to be 0 when a non-official quote is loaded and added.

@LucasGGamerM
Copy link
Owner

That wouldn't matter, since it will always reset to be 0 when a non-official quote is loaded and added.

No, not really. The RecyclerView's adapter updates, but the position is kept consistent. What I mean by that is that the recycler view doesn't scroll to the top every time a new quote status is added.

@FineFindus
Copy link
Author

Proper fix in 519cb67, 1829dc1 and 55ad624.

@FineFindus FineFindus closed this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants