fix: show profile picture in share sheet #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shows the profile picture of the shared account in the share sheet. This was already done upstream and intended here, but was bugged due to an additional file provider.
|
Oh btw did you make sure to fix up all the things that depended on the old file provider? |
|
The tweaked provider replaces the old one under the same name. |
Well, can you test if you can add a picture to a post directly from the Compose screen? The camera thingy depended on the old provider, but you didn't change the code, so maybe it doesn't work |
|
Imma merge this and fix it later |
|
Yup, the taking a picture from compose is broken from this. Time for refactoring! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shows the profile picture of the shared account in the share sheet. This was already done upstream and intended here, but was bugged due to an additional file provider.