Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: quote improvements #454

Merged
merged 3 commits into from
Jul 6, 2024
Merged

feat: quote improvements #454

merged 3 commits into from
Jul 6, 2024

Conversation

FineFindus
Copy link

No description provided.

FineFindus added 3 commits July 6, 2024 22:51
@FineFindus
fix(StatusDisplayItem/Quote): use correct method
9134526 
ChildFragments overwrite the buildDisplayItems to provide the correct
parameters, e.g. flags, additional items, etc. Call those instead of the
default one.
@FineFindus
fix(StatusDisplayItem/Quote): only update non-empty adapter
7240070 
Fixes a crash when updating an empty adapter. This was the case when
opening a status from a notification.
@FineFindus
feat(StatusDisplayItem/Quote): allow quotes to reference themselves
bc8b0e1
LucasGGamerM
LucasGGamerM approved these changes Jul 6, 2024
View reviewed changes
Copy link
Owner

@LucasGGamerM LucasGGamerM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is waaaay harder than I thought it would be

@LucasGGamerM LucasGGamerM merged commit 96ccb14 into LucasGGamerM:master Jul 6, 2024
1 check passed
@FineFindus FineFindus deleted the fix/quote-improvements branch July 7, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasGGamerM LucasGGamerM LucasGGamerM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FineFindus @LucasGGamerM