revert: readd haptic feedback setting on Android 11 and lower #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some OEMs do not implement a systemwide setting for touch feedback. This reverts commit e0a793e.
LucasGGamerM
approved these changes
May 28, 2024
There was a problem hiding this comment.
I think it'd be nice to have it for all android versions, and instead put a little disclaimer under the setting that the system may override this setting
There was a problem hiding this comment.
I heavily disagree with both the decision to remove the version restriction (since it's bad UX) and the merging of this PR (since it breaks the git history)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some OEMs do not implement a systemwide setting for touch feedback on older Android versions.
This reverts commit e0a793e.