Port the verified Archolos branch onto a pinned current upstream revision #13

Activity

1. Lu2cz

   added this to the Maintenance — Upstream and test foundations milestone on Sep 11, 2026
2. Lu2cz

   added

   maintenanceRepository, dependencies and repeatable validationRepository, dependencies and repeatable validation

   priority:normalUseful gameplay work after current blockersUseful gameplay work after current blockers

   needs-triageReview evidence and scope before implementationReview evidence and scope before implementation

   on Sep 11, 2026
3. Lu2cz

   added a parent issue on Sep 11, 2026

   • Roadmap: Archolos playable from beginning to end on macOS #1
4. Lu2cz commented on Sep 26, 2026

   

   Lu2cz

   on Sep 26, 2026

   OwnerAuthor

   More actions

   This was generated by AI during triage.

   Upstream review — 26 September 2026

   Read recent September commits, open/recent PR diffs and relevant maintainer discussion. No upstream code or dependencies applied to the playable app during this review. Local baseline inspected at 2d2692f.

   Highest-value candidates

   1. Item collision lifetime fix, merged upstream PR #993, commit d83c6db3. Changes stored callback capture from [&] to [owner]. Our game/physics/dynamicworld.cpp still captures the constructor's local owner pointer by reference; the delayed callback can dereference an expired stack reference. Good bounded backport candidate. Exercise dropped-item/weapon impact and combat/death paths; upstream Game crash on death Try/OpenGothic#984/[Gothic I] (maybe [Gothic II]?) item ground collision causing engine crash Try/OpenGothic#994 give reproduction context, not proof that every death crash is this bug.
   2. macOS upload wait, open PR #943, maps directly to our Investigate intermittent macOS loading stall in InstanceStorage::join #31's InstanceStorage::join sampled stack. Our branch still has the busy loop and unpredicated uploader wait. Strong diagnosis lead, not an accepted ready-made cure. Upstream maintainer requested consideration of separate condition variables and questioned root cause. Review notify_one routing if sharing a condition variable between main/uploader waiters; test work submission and shutdown as well as repeated loads. The PR's unrelated Cpu32 empty-string fix should not be duplicated blindly.
   3. Save-loading ZIP metadata/lifecycle, merged #988, commit 794d7971. Our Serialize retains the old per-entry file-stat scan and lacks its reader-end cleanup. Worth controlled load-time/memory measurement and a focused adaptation around our custom compatibility persistence. Do not replace Serialize wholesale or assume a measured speedup before testing.

   Useful secondary candidates

   • f04d28e6, walk/swim/dive bits and sneak toggling, follows closed PR Fix diving controls Try/OpenGothic#989. Our branch still has the older arrangement. Relevant before expanding swimming/diving coverage; requires movement/combat/animation regression tests.
   • 8821ef64, equal-size DrawClusters allocation reuse. Evaluate as part of Port the verified Archolos branch onto a pinned current upstream revision #13 renderer migration; applicability to the older renderer must be checked, not assumed.
   • 7f363876 updates Tempest for upload-resource lifetime/leak fixes. Shared UploadEngine and backend changes merit review during dependency migration; not proof of our Investigate intermittent macOS loading stall in InstanceStorage::join #31 cause. Avoid blindly moving the Tempest pin across a large divergent change set.
   • September 21 Tempest update 1df01f87 includes macOS cursor work, notably Tempest d323717a and 10b3cfe0. Also note OpenGothic fbb4794e, a follow-up regression fix to Fix cursor visibility on startup and focus Try/OpenGothic#980. Informational only: cursor remains deferred under project instructions.

   Watch rather than import now

   • Open #991 adds a custom saves directory. Useful for future packaging/test isolation, but our current separate working directories already solve that. Maintainer prefers broader #992 installation/config/save design first.
   • Closed/unmerged #987 restores Ikarus bindings on reload. Relevant corroboration of problems we solved, not a replacement for our broader persisted heap/mapping implementation. Upstream explicitly deferred DMA save/load design.
   • Open #953 mixes regeneration timing and line-of-sight changes for L’Hiver. No demonstrated equivalent Archolos regression yet; investigate only with evidence.
   • Recent editor work, Vulkan-specific swapchain work, Android/iOS packaging and Windows DirectMusic changes are lower relevance to our native Metal campaign target.

   Recommendation: bounded Try#993 adaptation, then #31 investigation informed by Try#943, then measured Try#988 adaptation. Full upstream/dependency migration remains #13, with carried-fix and save-compatibility review. These are recommendations, not newly started implementation tasks.