Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added How to use Coil Image Loading Library. #117

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

amaan118921
Copy link

Closes #52

@amaan118921
Copy link
Author

please review and let me know of the changes @jmfayard

@amaan118921
Copy link
Author

@jmfayard please review

Copy link
Collaborator

@jmfayard jmfayard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey thanks, I had actually already reviewed but forgot the crucial Submit review part

android/build.gradle.kts Outdated Show resolved Hide resolved
kotlin-jvm/build.gradle.kts Outdated Show resolved Hide resolved
@amaan118921
Copy link
Author

amaan118921 commented Oct 6, 2022

I have updated the code as per your suggestions and have added the commit, please review it @jmfayard

Comment on lines +17 to +19
private var ivFile: ImageView? = null
private var ivUrl: ImageView? = null
private var ivDrawable: ImageView? = null
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LouisCAD do you think those views should be nullable? I know nothing about Android

Copy link
Author

@amaan118921 amaan118921 Oct 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not nullable, we can initialize them later, but if we use lateinit, there might be possibility of views not being initialized, which would lead to crash of the application, so, i think this nullable would handle it correctly, since we are using a null operator while accessing the views.

import coil.load
import coil.transform.CircleCropTransformation
import coil.transform.RoundedCornersTransformation
import java.io.File


class CoilFragment : Fragment() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add links to the project repo and documentation?
That will greatly add new comers

/**
* jetbrains/markdown : Multiplatform Markdown processor written in Kotlin
*
* - [Website](https://github.com/JetBrains/markdown)
* - [Github](https://github.com/JetBrains/markdown)
*/
fun main(){
generateHtml()
}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have now added the references.

@amaan118921
Copy link
Author

you can have a look @jmfayard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sample wanted for coil-kt/coil
2 participants