-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added How to use Coil Image Loading Library. #117
base: main
Are you sure you want to change the base?
Conversation
please review and let me know of the changes @jmfayard |
@jmfayard please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the code as per your suggestions and have added the commit, please review it @jmfayard |
private var ivFile: ImageView? = null | ||
private var ivUrl: ImageView? = null | ||
private var ivDrawable: ImageView? = null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LouisCAD do you think those views should be nullable? I know nothing about Android
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If not nullable, we can initialize them later, but if we use lateinit, there might be possibility of views not being initialized, which would lead to crash of the application, so, i think this nullable would handle it correctly, since we are using a null operator while accessing the views.
import coil.load | ||
import coil.transform.CircleCropTransformation | ||
import coil.transform.RoundedCornersTransformation | ||
import java.io.File | ||
|
||
|
||
class CoilFragment : Fragment() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add links to the project repo and documentation?
That will greatly add new comers
kotlin-libraries-playground/kotlin-jvm/src/main/kotlin/playground/Markdown.kt
Lines 17 to 25 in ff3ae6a
/** | |
* jetbrains/markdown : Multiplatform Markdown processor written in Kotlin | |
* | |
* - [Website](https://github.com/JetBrains/markdown) | |
* - [Github](https://github.com/JetBrains/markdown) | |
*/ | |
fun main(){ | |
generateHtml() | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have now added the references.
you can have a look @jmfayard |
Closes #52