BME 119: Switch dependencies to use CurseMaven #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordFokas
reviewed
Jul 25, 2025
LordFokas
reviewed
Jul 28, 2025
| // implementation fg.deobf("_:ftb-chunks:${ftbchunks_version}") | ||
| // implementation fg.deobf("_:ftb-teams:${ftbteams_version}") | ||
| // implementation fg.deobf("_:ftb-library:$ftblib_version") | ||
| // implementation fg.deobf("_:architectury:${architectury_version}") |
There was a problem hiding this comment.
these commented out lines need to go as well, since they now reference variables that don't exist and with curse maven these are also artifacts that cannot be found
maddie-j
reviewed
Aug 25, 2025
Comment on lines
+71
to
+73
| // flatDir { | ||
| // dirs 'libs' | ||
| // } |
There was a problem hiding this comment.
Curious: What's the reason for leaving behind this commented code? Is this just something that needs clean up, or are there times it should be uncommented for some debugging mode?
Comment on lines
+11
to
+16
| # Curseforge File IDs | ||
| rubidium_file_id=4494903 | ||
| architectury_file_id=5137931 | ||
| ftbchunks_file_id=5423717 | ||
| ftbteams_file_id=4579981 | ||
| ftblib_file_id=4396792 |
There was a problem hiding this comment.
Could you leave a comment at the end of each line stating which version number each file ID represents? Makes lookup easier when debugging, especially when somebody sends us a logfile showing a potential mod conflict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also ran my formatter if there are other random lines in the build.gradle that got touched