Repository navigation
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 1
Please check the settings in the CodeRabbit UI or the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The setup behind today's Base review demo, so anyone can run it. @celinayang13, this is so you can pick up the demo from here if my laptop dies.
ros2/docker/demo.sh(run on the Mac, likefoxglove.sh): the gate stack in Gazebo with the GUI on noVNC and the Foxglove bridge onws://localhost:8765. Runs:lap(autocross seed 1),fault(steer_freezeat 8 m/s on the oval, safety stops the car),loop(rules_autocross seed 1),extreme(Autonomous: Add fixed extreme autocross scenarios #218's extreme_combined),fsi/fsg(Autonomous: import real competition track layouts #223's real layouts), plus<run> paused,pause,resume,stop.ros2/foxglove/lhr_gazebo_truth.jsonandtruth_relay.py: a layout that follows Gazebo's true pose instead of the EKF'sbase_link, so the view doesn't shake with estimator corrections. The steering plot also shows both front wheels' measured angles against the command. The relay republishes/tf_truthasmap -> truth_base_link, for display only.To take over on a Mac with the container built (docker README):
Gazebo is at http://localhost:6080/vnc.html?autoconnect=true&resize=scale. In Foxglove, open
ws://localhost:8765, then Layouts > Import from file >autonomy/ros2/foxglove/lhr_gazebo_truth.json.Caveats:
extreme,fsiandfsgpull their worlds from the unmerged Autonomous: Add fixed extreme autocross scenarios #218 and Autonomous: import real competition track layouts #223 branches and run them onmain's stack.mainhas noamz_*track style, so the legacy style stands in, with the layouts' median gate width and Autonomous: import real competition track layouts #223'smax_step_m:=8.world_vizcrashes on the imported layouts, so Foxglove shows no truth cones there. FSG went off course after 9 m in Autonomous: import real competition track layouts #223's own check, so FSI is the safer one to show.lapis the only one scored on a Mac.How it's tested
No automated test yet; this is a draft. The version on my Mac's Desktop (blue-crest), which this was copied from, ran today in the Mac container:
laptwice (33.6 s, 0 cones, max CTE 0.24 m, FINISHED), andfaulttwice (STEER_TRACKING1.3-1.6 s wall after the fault, EMERGENCY, stopped).loop,extremeandfsidrove for several minutes each with no trips; FSG was not run. The relay publishedmap -> truth_base_link(checked withtf2_echo) and the latched body markers. The repo copy differs: it fetches the #218/#223 worlds with git rather than reading copied files, it runs the relay from the checkout, and it addspaused,pauseandresume. That copy has not been run yet, so as not to disturb the live demo.bash -npasses. The strict docs build was not run locally.Checklist
README.mdupdated