Repository navigation
simulation: compute anti paths from the hardpoints, not KinPy - #186
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 30 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Safe to merge. I found no defect in the new twist solve or in the callers I could read. I read the full diff. The five link constraints are What I checkedChecked: the whole diff and the changed files. I confirmed the constraint-row algebra, the SVD null-space indexing, and the 5th-singular-value test for duplicate or parallel links. I checked the new Didn't check: I did not run Assumed: the statics oracle in the PR branch is independent of this solve and agrees at 1e-9, as the PR says. #185 is the base and this PR changes nothing else in the FourPost flow. Ultron reviewed 585e30d · it re-reviews on new pushes |
f1cfa4e to
585e30d
Compare
585e30d to
a238e3f
Compare
Why
tools/anti_paths.pyused BobSim KinPy to solve the corner at five jounce steps and take finite differences. KinPy may be deprecated. The anti coefficients need only first-order kinematics at the design pose.What changes
anti_paths.corner_coefficientssolves the upright twist directly. Each of the five links (four wishbone legs and the tie rod) keeps its length. The twist is the null space of a 5x6 linear system. It uses numpy only.invalid.bobsim_instant_linkcross-check.pose.kindis nowhardpoint_twist.docs/anti-paths.mddescribes the new method.Evidence
vehicle/vehicle.yml, all three coefficients equal the old KinPy values to 6 digits. Front: contact patch 0.005135, wheel center and virtual power −0.003893. Rear: −0.008952 and 0.004727.test_anti_paths.pynow compares with the statics oracle (tests/anti_oracle.py) at 1e-9, not at the old finite-difference tolerance.make test: 364 passed.Limits
studies/front-ackermann/run.pystill uses KinPy for full nonlinear steering geometry. It is a historical study and is not changed here.Stack
On #185.