Merge pull request #36 from Lombiq/issue/OSOE-833

OSOE-833: Upgrade PSScriptAnalyzer to 1.22
Lombiq · May 15, 2024 · 2ad1948 · 2ad1948
2 parents 2dc35d1 + a2f24b8
commit 2ad1948
Show file tree

Hide file tree

Showing 10 changed files with 24 additions and 24 deletions.
diff --git a/.../Sql/Save-AzureWebAppSqlDatabaseToRepository/Save-AzureWebAppSqlDatabaseToRepository.psm1 b/.../Sql/Save-AzureWebAppSqlDatabaseToRepository/Save-AzureWebAppSqlDatabaseToRepository.psm1
@@ -74,18 +74,18 @@ function Save-AzureWebAppSqlDatabaseToRepository
 
     Process
     {
-        if (!(Test-Path $RepositoryPath))
+        if (-not (Test-Path $RepositoryPath))
         {
             throw ("The folder `"$RepositoryPath`" can not be found!")
         }
 
         $destination = $RepositoryPath
 
-        if (!([string]::IsNullOrEmpty($RepositorySubPath)))
+        if (-not [string]::IsNullOrEmpty($RepositorySubPath))
         {
             $destination += "\$RepositorySubPath"
 
-            if (!(Test-Path $destination))
+            if (-not (Test-Path $destination))
             {
                 New-Item -ItemType Directory -Path $destination -Force
             }

diff --git a/...et-AzureWebAppSqlDatabaseServiceObjective/Set-AzureWebAppSqlDatabaseServiceObjective.psm1 b/...et-AzureWebAppSqlDatabaseServiceObjective/Set-AzureWebAppSqlDatabaseServiceObjective.psm1
@@ -79,10 +79,10 @@ function Set-AzureWebAppSqlDatabaseServiceObjective
         $serviceObjectives = Get-AzSqlServerServiceObjective -ResourceGroupName $database.ResourceGroupName -ServerName $database.ServerName
 
         $availableServiceObjectiveNames = $serviceObjectives |
-            Where-Object { !$PSItem.IsSystem -and $PSItem.Enabled } |
+            Where-Object { -not $PSItem.IsSystem -and $PSItem.Enabled } |
             Select-Object -ExpandProperty 'ServiceObjectiveName'
 
-        if (!$availableServiceObjectiveNames.Contains($ServiceObjectiveName))
+        if (-not $availableServiceObjectiveNames.Contains($ServiceObjectiveName))
         {
             throw ("The `"$ServiceObjectiveName`" tier is not available for the server `"$($database.ServerName)`". " +
                 "The available tiers are:`n$([string]::Join(', ', $availableServiceObjectiveNames)).")

diff --git a/...rShell/Azure/Storage/Invoke-AzureWebAppStorageAzCopy/Invoke-AzureWebAppStorageAzCopy.psm1 b/...rShell/Azure/Storage/Invoke-AzureWebAppStorageAzCopy/Invoke-AzureWebAppStorageAzCopy.psm1
@@ -222,7 +222,7 @@ function Invoke-AzureWebAppStorageAzCopy
         # Preparing to validate the list of source containers.
         $containerIncludeListValid = $ContainerIncludeList -and $ContainerIncludeList.Count -gt 0
         $sourceContainers = $sourceStorageContext | Get-AzStorageContainer |
-            Where-Object { !$containerIncludeListValid -or ($containerIncludeListValid -and $ContainerIncludeList.Contains($PSItem.Name)) }
+            Where-Object { -not $containerIncludeListValid -or ($containerIncludeListValid -and $ContainerIncludeList.Contains($PSItem.Name)) }
         $sourceContainerNames = $sourceContainers | Select-Object -ExpandProperty 'Name'
 
         # Throwing error if none of the source containers exist.

diff --git a/PowerShell/Azure/Storage/Save-AzureWebAppStorageContent/Save-AzureWebAppStorageContent.psm1 b/PowerShell/Azure/Storage/Save-AzureWebAppStorageContent/Save-AzureWebAppStorageContent.psm1
@@ -124,8 +124,8 @@ function Save-AzureWebAppStorageContent
 
         $containers = Get-AzStorageContainer -Context $storageContext |
             Where-Object {
-            ((!$containerWhiteListValid -or ($containerWhiteListValid -and $ContainerWhiteList.Contains($PSItem.Name))) -and
-                ($containerWhiteListValid -or (!$containerBlackListValid -or !$ContainerBlackList.Contains($PSItem.Name))))
+            ((-not $containerWhiteListValid -or ($containerWhiteListValid -and $ContainerWhiteList.Contains($PSItem.Name))) -and
+                ($containerWhiteListValid -or (-not $containerBlackListValid -or -not $ContainerBlackList.Contains($PSItem.Name))))
             }
 
         $folderWhiteListValid = $FolderWhiteList -and $FolderWhiteList.Count -gt 0
@@ -149,10 +149,10 @@ function Save-AzureWebAppStorageContent
             }
             $blobs = $container | Get-AzStorageBlob |
                 Where-Object {
-                (!$folderWhiteListValid -or ($folderWhiteListValid -and
+                (-not $folderWhiteListValid -or ($folderWhiteListValid -and
                     (Compare-Object $PSItem.Name.Split('/', [StringSplitOptions]::RemoveEmptyEntries) $FolderWhiteList @comparisonParameters))) -and
-                (!$folderBlackListValid -or ($folderBlackListValid -and
-                    (!(Compare-Object $PSItem.Name.Split('/', [StringSplitOptions]::RemoveEmptyEntries) $FolderBlackList @comparisonParameters))))
+                (-not $folderBlackListValid -or ($folderBlackListValid -and
+                    (-not (Compare-Object $PSItem.Name.Split('/', [StringSplitOptions]::RemoveEmptyEntries) $FolderBlackList @comparisonParameters))))
                 }
 
             foreach ($blob in $blobs)

diff --git a/...ge/Set-AzureWebAppStorageContentFromStorage/Set-AzureWebAppStorageContentFromStorage.psm1 b/...ge/Set-AzureWebAppStorageContentFromStorage/Set-AzureWebAppStorageContentFromStorage.psm1
@@ -166,8 +166,8 @@ function Set-AzureWebAppStorageContentFromStorage
 
         $sourceContainers = $sourceStorageContext | Get-AzStorageContainer |
             Where-Object {
-                ((!$containerWhiteListValid -or ($containerWhiteListValid -and $ContainerWhiteList.Contains($PSItem.Name))) -and
-                ($containerWhiteListValid -or (!$containerBlackListValid -or !$ContainerBlackList.Contains($PSItem.Name))))
+                ((-not $containerWhiteListValid -or ($containerWhiteListValid -and $ContainerWhiteList.Contains($PSItem.Name))) -and
+                ($containerWhiteListValid -or (-not $containerBlackListValid -or -not $ContainerBlackList.Contains($PSItem.Name))))
             }
         $sourceContainerNames = $sourceContainers | Select-Object -ExpandProperty 'Name'
 
@@ -237,7 +237,7 @@ function Set-AzureWebAppStorageContentFromStorage
                         Start-Sleep 5
                     }
                 }
-                while (!$containerCreated)
+                while (-not $containerCreated)
             }
 
             Write-Output ("`n*****`nCopying blobs from `"$($sourceContainer.Name)`" to `"$destinationContainerName`"`n*****")
@@ -257,10 +257,10 @@ function Set-AzureWebAppStorageContentFromStorage
                         ExcludeDifferent = $true
                     }
 
-                    if ((!$folderWhiteListValid -or
+                    if ((-not $folderWhiteListValid -or
                         ($folderWhiteListValid -and (Compare-Object $blobNameElements $FolderWhiteList @comparisonParameters))) -and
-                    (!$folderBlackListValid -or
-                        ($folderBlackListValid -and (!(Compare-Object $blobNameElements $FolderBlackList @comparisonParameters)))))
+                    (-not $folderBlackListValid -or
+                        ($folderBlackListValid -and (-not (Compare-Object $blobNameElements $FolderBlackList @comparisonParameters)))))
                     {
                         $copyParameters = @{
                             Context = $sourceStorageContext

diff --git a/PowerShell/Azure/Websites/Switch-AzureWebAppSlots/Switch-AzureWebAppSlots.psm1 b/PowerShell/Azure/Websites/Switch-AzureWebAppSlots/Switch-AzureWebAppSlots.psm1
@@ -491,7 +491,7 @@ function UpdateWebAppSlotAppSettingsAndConnectionStrings
                 Write-Warning "Attempt #$retryCounter to update the `"$SlotName`" Slot of `"$WebAppName`" failed. Retrying..."
             }
         }
-        while (!$success)
+        while (-not $success)
 
         return $slot
     }
@@ -533,7 +533,7 @@ function VerifyAppSettingsValidity
             }
         }
 
-        if (!$appSettingsValid)
+        if (-not $appSettingsValid)
         {
             Write-Error ("`n*****`nERROR: THE `"$SlotName`" SLOT'S APP SETTINGS ARE INVALID!`n*****`n")
         }
@@ -585,7 +585,7 @@ function VerifyConnectionStringsValidity
             }
         }
 
-        if (!$connectionStringsValid)
+        if (-not $connectionStringsValid)
         {
             Write-Error ("`n*****`nERROR: THE `"$SlotName`" SLOT'S CONNECTION STRINGS ARE INVALID!`n*****`n")
         }

diff --git a/PowerShell/HostingSuite/Get-Maintenance/Get-Maintenance.psm1 b/PowerShell/HostingSuite/Get-Maintenance/Get-Maintenance.psm1
@@ -79,7 +79,7 @@ function Get-Maintenance
                 Write-Warning "Requesting the status of the maintenance `"$MaintenanceName`" at `"$Hostname`" failed. Retrying..."
             }
         }
-        while (!$success)
+        while (-not $success)
 
         if ($result.StatusCode -eq 200)
         {

diff --git a/PowerShell/HostingSuite/Start-Maintenance/Start-Maintenance.psm1 b/PowerShell/HostingSuite/Start-Maintenance/Start-Maintenance.psm1
@@ -101,7 +101,7 @@ function Start-Maintenance
                 Write-Warning "Starting the maintenance `"$MaintenanceName`" at `"$Hostname`" failed. Retrying..."
             }
         }
-        while (!$success)
+        while (-not $success)
 
         if ($result.StatusCode -ne 201)
         {

diff --git a/PowerShell/TeamCity/Start-TCBuild/Start-TCBuild.psm1 b/PowerShell/TeamCity/Start-TCBuild/Start-TCBuild.psm1
@@ -47,7 +47,7 @@
                 Write-Warning "Triggering `"$BuildId`" failed. Retrying..."
             }
         }
-        while (!$success)
+        while (-not $success)
 
         Write-Output "Successfully triggered `"$BuildId`"!"
     }

diff --git a/PowerShell/Utilities/Test-Url/Test-Url.psm1 b/PowerShell/Utilities/Test-Url/Test-Url.psm1
@@ -65,7 +65,7 @@ function Test-Url
                 Start-Sleep -Seconds $Interval
             }
         }
-        while (!$success)
+        while (-not $success)
 
         return $success
     }