This repository was archived by the owner on Dec 14, 2023. It is now read-only.
Make the port number configurable. #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed the predefined constants. - Removed property for DataHub port. - Removed datahubPort argument from constructor. - Added port argument to constructor. - Return port property when calling getPort().
added 4 commits
December 23, 2015 10:05
The address should be data.logentries.com for TCP connections, according to https://logentries.com/doc/input-token/.
The only supported port for TLS is 2000.
|
@olofjohansson sorry no one has looked at this sooner. One thing I would like to see though is a default port to be used in case a user does not submit it. Ideally port 443 with SSL enabled. |
| private $use_datahub = false; | ||
| private $_datahubPort = 10000; | ||
|
|
||
| private $port = false; |
There was a problem hiding this comment.
A default port should be specified (10000) to avoid breaking current usage.
- Added new parameter to constructor which sets the connection timeout to Logentires requests. - The timeout parameter should be defined in seconds.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to do this since some hosts block communication on non standard ports, e.g. 10000. But Logentries supports various ports, so this is easily avoidable by making the port configurable.
I'm not 100% sure about how the DataHub integration works, but this approach aims at keeping a single port for the entire instance by making it configurable via the constructor.