update enent listerner to handle querySelectorAll and return event#1
Open
drifterz28 wants to merge 2 commits intoLochlan:masterfrom
Open
update enent listerner to handle querySelectorAll and return event#1drifterz28 wants to merge 2 commits intoLochlan:masterfrom
drifterz28 wants to merge 2 commits intoLochlan:masterfrom
Conversation
Owner
|
@drifterz28 Nice to hear from you :) Sorry I haven't looked at your PR yet, I will try to do so soon. I'm curious: are you using this in production somewhere? |
Author
|
It might be used someday in production but no plans yet and I am using it to build a prototype. |
Author
|
I would be more than happy to take over this if you would like? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found it nice to target elements and not have to be locked down to an ID and having to new up a new simple swipe for every element.