fix(ci): add safe.directory for git in CI containers#8
Merged
Merged
Conversation
The build-srpm.sh script fails in CI containers with "Not in a git repository" because git refuses to operate on directories owned by a different user. Add git safe.directory config to fix ownership mismatch when running as root in containerized CI jobs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe build script adds a Git configuration command to mark the repository root as a trusted "safe directory" before executing subsequent git operations. This suppresses ownership/safety errors and allows the script to run in restricted environments where Git enforces ownership checks. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
maxamillion
added a commit
that referenced
this pull request
Mar 30, 2026
The build-srpm.sh script fails in CI containers with "Not in a git repository" because git refuses to operate on directories owned by a different user. Add git safe.directory config to fix ownership mismatch when running as root in containerized CI jobs. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Adam Miller <admiller@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build-srpm.shfailing with "Not in a git repository" in CI containersgit config --global --add safe.directorybefore the git repo checkThis fixes all RPM Repository workflow runs which have been failing since the workflow was introduced.
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit