Skip to content

fix(ci): move aarch64 repo preparation inside QEMU container#11

Merged
maxamillion merged 1 commit into
mainfrom
rpm
Mar 30, 2026
Merged

fix(ci): move aarch64 repo preparation inside QEMU container#11
maxamillion merged 1 commit into
mainfrom
rpm

Conversation

@maxamillion

@maxamillion maxamillion commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • The 'Prepare repo directory' step ran on the Ubuntu host which lacks createrepo_c (exit code 127)
  • Moved repo prep + createrepo_c into the run-on-arch-action run block
  • Volume-mount output directory so the upload step can access the built repo

Test plan

  • Verify aarch64 RPM builds complete and the repo artifact is uploaded

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Refactor

    • Restructured RPM build workflow to consolidate package compilation and repository metadata generation into a unified container-based operation, reducing workflow complexity and improving overall CI/CD efficiency.
  • Chores

    • Updated artifact output directory structure to improve organization, accessibility, and management of generated package repositories and build deliverables.

@coderabbitai

coderabbitai Bot commented Mar 30, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 40dd5dcf-7900-4bc0-bb5b-3e67bb22dd4d

📥 Commits

Reviewing files that changed from the base of the PR and between 198f1c5 and 7e042b2.

📒 Files selected for processing (1)
  • .github/workflows/rpm-repo.yml

📝 Walkthrough

Walkthrough

The build-rpms-aarch64 job consolidates RPM build output handling and repository generation into a single container step. Container volume mounts change from /rpms to /output. The separate "Prepare repo directory" step is removed, merging its logic into the unified build step. Repository generation now occurs inside the container, and artifact upload paths are updated accordingly.

Changes

Cohort / File(s) Summary
GitHub Actions RPM Build Workflow
.github/workflows/rpm-repo.yml
Consolidates RPM build output handling and repository generation into a single container step in the build-rpms-aarch64 job. Container volume mount changes from ${{ github.workspace }}/rpms/rpms to ${{ github.workspace }}/output/output. Removes separate "Prepare repo directory" step. Adds in-container directory creation, RPM copying, debug info stripping, and createrepo_c execution. Updates artifact upload path from repo/ to output/repo/.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 Containers dance with mounted grace,
Output paths now find their place,
One step combines what two once were,
RPMs bundle, repos purr,
Workflow simplified—hip, hip, hooray! 🎉

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: moving aarch64 repo preparation into the QEMU container to fix the createrepo_c availability issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch rpm

Comment @coderabbitai help to get the list of available commands and usage tips.

The "Prepare repo directory" step runs on the Ubuntu host which lacks
createrepo_c (exit code 127). Move repo preparation into the
run-on-arch-action run block where createrepo_c is installed, and
volume-mount the output directory so the upload step can access it.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Adam Miller <admiller@redhat.com>
@maxamillion maxamillion merged commit d9e1b88 into main Mar 30, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant