fix: enable Fedora repos and fix package availability in Hummingbird images#9
Merged
Merged
Conversation
…images The Hummingbird repository contains a curated subset of packages and does not include protobuf-compiler, iptables, socat, or rsync. Enable the standard Fedora repositories via 'dnf install -y fedora-repos' before installing these packages. Also switches k9s and helm download stages from hummingbird/curl (which lacks curl and tar) to core-runtime:latest-builder with curl, tar, and gzip installed explicitly. Adds ca-certificates to the nvidia-container-toolkit stage to fix SSL cert errors when fetching the NVIDIA RPM repository. Signed-off-by: Adam Miller <admiller@redhat.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The Hummingbird container images use a curated package repository that does not include many standard Fedora packages (
protobuf-compiler,iptables,socat,rsync,curl,tar). Additionally, thehummingbird/curl:latest-builderimage lackscurlandtarbinaries, and thenvidia-container-toolkitstage fails SSL cert validation.Fix
dnf install -y fedora-reposas the first step in stages that need packages outside the Hummingbird repo (rust-builder, cluster, CI image)hummingbird/curl:latest-buildertocore-runtime:latest-builderwithcurl,tar,gzipinstalled explicitlyTesting
After merging, trigger all image builds: