fix: add USER root to Hummingbird builder stages for dnf access#8
Merged
Merged
Conversation
Hummingbird builder images default to non-root UID 65532. All stages that run dnf install or write to system directories need USER root before executing privileged operations. Affected stages: - Dockerfile.images: rust-builder-base, nvidia-container-toolkit, cluster - Dockerfile.ci: main stage - examples/bring-your-own-container/Dockerfile Signed-off-by: Adam Miller <admiller@redhat.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
All Hummingbird
:latest-builderimages run as non-root by default (UID 65532). Thednf installcommands and writes to system directories (/etc/yum.repos.d/) fail with "Permission denied" or "requires superuser privileges".Fix
Adds
USER rootimmediately after theFROMdirective in every stage that runs privileged operations:deploy/docker/Dockerfile.imagesrust-builder-base,nvidia-container-toolkit,clusterdeploy/docker/Dockerfile.ciexamples/bring-your-own-container/DockerfileThe gateway image (
core-runtime:latest-openssl) is unaffected — it's distroless and doesn't rundnf.Testing
After merging, trigger the container builds: