fix(cluster): revert nftables kube-proxy mode detection#20
Merged
Conversation
The nftables kube-proxy mode detection added in PR #18 breaks NodePort routing on hosts where nft is available (including Fedora 43). When kube-proxy runs in nftables mode, the gateway service NodePort (30051) becomes unreachable, causing the health check to time out and the gateway start to fail. The modules-load.d config shipped by the RPM already ensures the legacy iptables kernel modules are loaded, which is the correct fix for the original problem. Remove the nftables detection until k3s nftables mode is validated with the full openshell gateway service configuration.
maxamillion
requested review from
cgwalters,
fatherlinux,
openchow and
sallyom
as code owners
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts the nftables kube-proxy mode detection added in PR #18. The detection breaks NodePort routing on hosts where
nftis available, causing the gateway health check to time out on Fedora 43.Related Issue
Follow-up fix to PR #18 (
fix(rpm): resolve Fedora 43 install and runtime failures).Changes
KUBE_PROXY_MODEdetection block fromdeploy/docker/cluster-entrypoint.sh$KUBE_PROXY_MODEfrom the finalexec /bin/k3slineRoot cause: When the entrypoint detects
nft list tablessucceeds, it sets--kube-proxy-arg=proxy-mode=nftables. While kube-proxy nftables mode is GA in Kubernetes 1.35, it does not correctly set up NodePort rules in the k3s + flannel configuration used by openshell. The gateway service NodePort (30051) becomes unreachable, socurl https://localhost:30051/healthfails and the CLI times out waiting for the health check.The
/etc/modules-load.d/openshell.confconfig shipped by the RPM (also from PR #18) already solves the original iptables problem by ensuring legacy kernel modules are loaded at boot. That fix remains in place and is the correct approach.Testing
Verified on a fresh Fedora 43 (x86_64) instance with Podman 5.8.1:
0.0.22-dev.71+g5085967e2)mise run pre-commitpassesChecklist