Skip to content

fix: add tar/gzip to rust builder and fix SSL certs in nvidia-ctk stage#11

Merged
maxamillion merged 1 commit into
LobsterTrap:midstreamfrom
maxamillion:container-builds
Apr 3, 2026
Merged

fix: add tar/gzip to rust builder and fix SSL certs in nvidia-ctk stage#11
maxamillion merged 1 commit into
LobsterTrap:midstreamfrom
maxamillion:container-builds

Conversation

@maxamillion

Copy link
Copy Markdown

Summary

  • Fixes two remaining container image build failures.

Problem 1: tar: command not found in rust-builder-base

The cross-build.sh script uses tar to extract sccache, but the Hummingbird rust:latest-builder image doesn't include tar or gzip. Both gateway and cluster builds fail at the install_sccache step.

Problem 2: SSL cert error in nvidia-container-toolkit stage

The nvidia-container-toolkit stage installs ca-certificates but the cert bundle at /etc/pki/tls/certs/ca-bundle.crt is not populated. This causes dnf to fail when fetching the NVIDIA RPM repository over HTTPS. The fix is to install fedora-repos (for the full cert package) and run update-ca-trust to generate the bundle.

Fix

  1. Add tar gzip to the rust-builder-base dnf install line
  2. Add fedora-repos and update-ca-trust to the nvidia-container-toolkit stage before fetching the NVIDIA repo

The Hummingbird rust:latest-builder image lacks tar and gzip, which
cross-build.sh needs to extract sccache. Add both to the dnf install.

The nvidia-container-toolkit stage needs fedora-repos for the full
ca-certificates package, plus update-ca-trust to populate the cert
bundle at /etc/pki/tls/certs/ca-bundle.crt that dnf's curl uses
for SSL verification.

Signed-off-by: Adam Miller <admiller@redhat.com>
@coderabbitai

coderabbitai Bot commented Apr 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a755c144-dee5-4dbe-933c-a62911d51ad2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@maxamillion maxamillion merged commit c5c768f into LobsterTrap:midstream Apr 3, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant