fix: add tar/gzip to rust builder and fix SSL certs in nvidia-ctk stage#11
Merged
Merged
Conversation
The Hummingbird rust:latest-builder image lacks tar and gzip, which cross-build.sh needs to extract sccache. Add both to the dnf install. The nvidia-container-toolkit stage needs fedora-repos for the full ca-certificates package, plus update-ca-trust to populate the cert bundle at /etc/pki/tls/certs/ca-bundle.crt that dnf's curl uses for SSL verification. Signed-off-by: Adam Miller <admiller@redhat.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem 1:
tar: command not foundin rust-builder-baseThe
cross-build.shscript usestarto extract sccache, but the Hummingbirdrust:latest-builderimage doesn't includetarorgzip. Both gateway and cluster builds fail at theinstall_sccachestep.Problem 2: SSL cert error in nvidia-container-toolkit stage
The nvidia-container-toolkit stage installs
ca-certificatesbut the cert bundle at/etc/pki/tls/certs/ca-bundle.crtis not populated. This causesdnfto fail when fetching the NVIDIA RPM repository over HTTPS. The fix is to installfedora-repos(for the full cert package) and runupdate-ca-trustto generate the bundle.Fix
tar gzipto the rust-builder-basednf installlinefedora-reposandupdate-ca-trustto the nvidia-container-toolkit stage before fetching the NVIDIA repo