feat(rpm): add packit configuration and RPM spec file#10
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
50a2580 to
3ea498a
Compare
Add RPM packaging for OpenShell with Packit-as-a-Service integration for automated COPR builds on pull requests. - openshell.spec: RPM spec with CLI binary and python3-openshell SDK subpackage, vendored Cargo dependencies for offline builds - .packit.yaml: Packit config deriving Version from the upstream NVIDIA/OpenShell tag at the midstream/main merge-base, with automated COPR builds for fedora-all and epel-10 targets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add RPM packaging with Packit-as-a-Service integration for automated COPR builds.
openshell.spec: RPM spec producing two packages:openshell-- the CLI binarypython3-openshell-- the Python SDK subpackageSource1) for hermetic offline builds.packit.yaml: Packit configuration with two build jobs:fedora-all+epel-10) -- triggered on every pull request for CI validationmaxamillion/openshellCOPR -- triggered on GitHub releasesVersioning Strategy
The
get-current-versionaction derives the RPM Version from the upstreamNVIDIA/OpenShell release tag at the
midstream/mainmerge-base:This means:
0.0.21)0.(e.g.,0.1.20260403gitd92caee2.pr9) clearly marking them as dev cuts1%{?dist}mainis synced to a new upstream tag, the Version bumps automaticallyPrerequisites
v*tags must be synced to this repo (git push origin --tagsafter fetching from upstream)maxamillion/openshellmust listgithub.com/LobsterTrap/OpenShellin allowed forge projects (done)Testing
packit srpmsucceeds locally and produces a valid SRPM