Added Package Configuration + Github Action Workflow for PRs #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks cool, I never got around to learning how to use github actions myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package Configuration
To simplify the process of supplying a zip file for testing for new changes I have created a new Package Configuration.
This Configuration will first run
manifest.pyto update the controller bindings, then build thed3d9.dllfile, and finally runmakerelease.batto package everything together in the 'HaloCEVR.zip' file.To do this simply change the Configuration in Visual Studio to
Packageand then build.Package Pull Request Action
I have also created a new Github Action Workflow for automatically Running the Package Configuration for Pull Requests into Master. This means that when a new change is pushed to the Pull Request the changes will be automatically built and packaged in a 'HaloCEVR.zip' file. This will let contributors know if the changes will build correctly and will provide a ZIP file for any reviewers to test the latest changes.
I'm not sure what the Repositories "Approval for running fork pull request workflows from contributors" is set to but I believe that contributors will first need approval before the workflow will run for their PRs.
To view an example of this workflow see the actions on my forked repository here: https://github.com/97saundersj/HaloCEVR/actions
I would also be happy to create more workflows in the future e.g. for automatically generating a zip file when the Master branch is updated, or to make the bindings get generated with the other Configurations to make sure that they are always up to date.
As always any feedback is appreciated.