Feature/transparent import maps #1765
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merryman
force-pushed
the
feature/transparent-import-maps
branch
from
31e85ef to
9e5fce9
Compare
Apparently there is javascript code that manually freezes the classes/prototypes after they have been defined, which makes the in place re-initialization crash. We now add an additional check in the transformed class that avoids running into that conflict.
Previously we would recycle the module url to pkg cache to allow us to retrieve the correct import map, which failed. We now use a dedicated import map cache, that takes care of merging overlapping import maps between different packages.
Parsing would sometimes fail in order to generate the needed ast nodes, due to variables defined outside of the parsed block.
Some of the previous changes caused crashes in the runtime source transform for lively.modules.
Source maps make the prettification unnessecary.
For some reason this appears to be nessecary with async modules.
This removes warnings from the bundling scripts.
for debug builds, it appears that rollup requires a lot of memory to process the source maps.
Some deps, need explicit mapping since either ga.jspm.io has a bug, or we have code that executes in the browser and in node.js.
merryman
force-pushed
the
feature/transparent-import-maps
branch
from
5a06385 to
619f4a2
Compare
merryman
force-pushed
the
feature/transparent-import-maps
branch
from
8798770 to
9e5b53e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Among other things, fixes #1640.
Still causes the builds to be much slower, due to the larger number of modules getting processed.
Will try to improve the performance here.
This PR depends on #1743 and consequently #1710.
Cannot be merged before.