Skip to content

Commit

Permalink
Resolve revision property in POMs (#268)
Browse files Browse the repository at this point in the history
The `revision` property is used to consolidate the configuration of the
modules' versions.  Since we want to deploy these artifacts, that
property must be resolved in order for Maven to find the parents later.

See [Maven CI Friendly Versions][1]

[1]: https://maven.apache.org/maven-ci-friendly.html

Reviewer: giacomo.calmasini
  • Loading branch information
rupertchen authored Jun 10, 2020
1 parent 6bf55a6 commit 52ec457
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
.bundle
# Created by flatten-maven-plugin
.flattened-pom.xml
build
src/java/com/rapleaf/jack/util/MysqlFlex.java
*.iml
Expand Down
30 changes: 30 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,31 @@
</configuration>
</plugin>

<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>flatten-maven-plugin</artifactId>
<executions>
<execution>
<id>flatten</id>
<phase>process-resources</phase>
<goals>
<goal>flatten</goal>
</goals>
<configuration>
<updatePomFile>true</updatePomFile>
<flattenMode>resolveCiFriendliesOnly</flattenMode>
</configuration>
</execution>
<execution>
<id>flatten.clean</id>
<phase>clean</phase>
<goals>
<goal>clean</goal>
</goals>
</execution>
</executions>
</plugin>

</plugins>

<pluginManagement>
Expand All @@ -99,6 +124,11 @@
<artifactId>maven-surefire-plugin</artifactId>
<version>2.22.2</version>
</plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>flatten-maven-plugin</artifactId>
<version>1.2.2</version>
</plugin>
</plugins>
</pluginManagement>
</build>
Expand Down

0 comments on commit 52ec457

Please sign in to comment.